Skip to content

[ci] : Remove deprecated options on unit-test action#510

Merged
sebsto merged 6 commits intoawslabs:mainfrom
sebsto:sebsto/fix_ci_509
Mar 20, 2025
Merged

[ci] : Remove deprecated options on unit-test action#510
sebsto merged 6 commits intoawslabs:mainfrom
sebsto:sebsto/fix_ci_509

Conversation

@sebsto
Copy link
Copy Markdown
Collaborator

@sebsto sebsto commented Mar 18, 2025 •
edited
Loading

Attempt to fix CI

Remove usage of deprecated parameters on unit-test.

  • explicitly enable tests on nightly 6.0
  • explicitly enable tests on nightly next
  • explicitly enable tests on nightly main

At the time of this writing, this resolves to

linux_6_0_container_image="swift:6.0-jammy"
linux_nightly_next_container_image="swiftlang/swift:nightly-6.1-jammy"
linux_nightly_main_container_image="swiftlang/swift:nightly-main-jammy"

@sebsto sebsto added the 🔨 semver/patch No public API change. label Mar 18, 2025
@sebsto sebsto self-assigned this Mar 18, 2025
@sebsto sebsto added this to the 2.0 milestone Mar 18, 2025
@sebsto sebsto requested review from FranzBusch and fabianfett March 18, 2025 17:18
@sebsto sebsto mentioned this pull request Mar 18, 2025
Closed
@sebsto
Copy link
Copy Markdown
Collaborator Author

sebsto commented Mar 18, 2025 •
edited
Loading

This should address #509

@sebsto sebsto changed the title [fix 509] : Remove test on nightly-main [ci] : fix 509 - Remove test on nightly-main Mar 18, 2025
@sebsto sebsto changed the title [ci] : fix 509 - Remove test on nightly-main [ci] : fix 509 - Disable unit tests on nightly-main Mar 18, 2025
fabianfett
fabianfett suggested changes Mar 19, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not disable nightly-main if it fails.

@sebsto
Copy link
Copy Markdown
Collaborator Author

sebsto commented Mar 19, 2025

@fabianfett OK. I keep this PR open because I removed the deprecated properties.

The last commit re-enabled linux_nightly_main_enabled

@sebsto
Copy link
Copy Markdown
Collaborator Author

sebsto commented Mar 19, 2025

crash is reported on Swiftlang project
swiftlang/swift#80115 (comment)

@sebsto sebsto requested a review from fabianfett March 19, 2025 17:34
fabianfett
fabianfett reviewed Mar 19, 2025
View reviewed changes
Comment thread .github/workflows/pull_request.yml
fabianfett
fabianfett reviewed Mar 19, 2025
View reviewed changes
Comment thread .github/workflows/pull_request.yml
fabianfett
fabianfett reviewed Mar 19, 2025
View reviewed changes
Comment thread .github/workflows/pull_request.yml
@fabianfett
Copy link
Copy Markdown
Collaborator

fabianfett commented Mar 19, 2025

Please rename PR then :)

@sebsto sebsto changed the title [ci] : fix 509 - Disable unit tests on nightly-main [ci] : fix 509 - removed deprecated option on unit-test action Mar 19, 2025
sebsto and others added 3 commits March 19, 2025 19:21
@sebsto @fabianfett
Update .github/workflows/pull_request.yml
e6669eb 
Co-authored-by: Fabian Fett <fabianfett@apple.com>
@sebsto @fabianfett
Update .github/workflows/pull_request.yml
86e0841 
Co-authored-by: Fabian Fett <fabianfett@apple.com>
@sebsto @fabianfett
Update .github/workflows/pull_request.yml
9aac126 
Co-authored-by: Fabian Fett <fabianfett@apple.com>
@sebsto sebsto requested a review from fabianfett March 19, 2025 18:28
@sebsto sebsto changed the title [ci] : fix 509 - removed deprecated option on unit-test action [ci] : Removed deprecated options on unit-test action Mar 19, 2025
@sebsto sebsto changed the title [ci] : Removed deprecated options on unit-test action [ci] : Remove deprecated options on unit-test action Mar 19, 2025
@fabianfett fabianfett added semver/none No version bump required. and removed 🔨 semver/patch No public API change. labels Mar 20, 2025
@sebsto sebsto merged commit 8939095 into awslabs:main Mar 20, 2025
30 of 31 checks passed
@sebsto sebsto deleted the sebsto/fix_ci_509 branch March 20, 2025 19:04
ktoso added a commit that referenced this pull request May 16, 2025
@ktoso
Revert "[ci] : Remove deprecated options on unit-test action (#510)"
700ce1d 
This reverts commit 8939095.
@ktoso ktoso mentioned this pull request May 16, 2025
Merged
sebsto pushed a commit that referenced this pull request May 16, 2025
@ktoso
Revert "[ci] : Remove deprecated options on unit-test action" (#513)
c7df9bc 
Reverts #510

I think the issue
#509 that
caused this tests disabling has been resolved in Swift and would like to
confirm here as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FranzBusch FranzBusch Awaiting requested review from FranzBusch

1 more reviewer

@fabianfett fabianfett fabianfett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sebsto sebsto

Labels

semver/none No version bump required.

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sebsto @fabianfett